[material-ui][Checkbox][Radio] Fix theme style overrides not working for different sizes #39377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Netlify deploy previewhttps://deploy-preview-39377--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
danilo-leal
changed the title
danilo-leal
added
component: checkbox
There was a problem hiding this comment.
Please add tests for both the Checkbox and Radio components. You can refer to this as an example: link.
ZeeshanTamboli
added
bug 🐛
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
|
@ZeeshanTamboli We have added the tests. Thanks for pointing that out. |
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
ZeeshanTamboli
approved these changes
Oct 20, 2023
ZeeshanTamboli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing override size styles to Checkbox and Radio components.
Closes #39303
Before: https://codesandbox.io/s/zen-vaughan-882wlf?file=/src/App.tsx
After: https://codesandbox.io/s/angry-agnesi-vw85h6
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.