Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui][Skeleton] Fix semi-transparent scenario when with surface components and color inversion #39400

Merged

Conversation

AkshitSinghal224
Copy link
Contributor

@AkshitSinghal224 AkshitSinghal224 commented Oct 11, 2023

Closes #39348

Before After
image The Skeleton appears slightly transparent, revealing the text underneath. image Now, the Skeleton is opaque and hides the text underneath.

Sorry, something went wrong.

@mui-bot
Copy link

mui-bot commented Oct 11, 2023

Netlify deploy preview

https://deploy-preview-39400--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 6b12f48

@danilo-leal danilo-leal changed the title Fix Skeleton issue when placed over a surface component with color in version, it gets semi-transparent #39348 [joy-ui][Skeleton] Fix semi-transparent scenario when with surface components and color inversion Oct 11, 2023
@danilo-leal danilo-leal added component: skeleton This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Oct 11, 2023
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for contributing @TheNatkat 🤝

@danilo-leal danilo-leal merged commit f0a1028 into mui:master Oct 11, 2023
@AkshitSinghal224
Copy link
Contributor Author

AkshitSinghal224 commented Oct 11, 2023

You're welcome! If you have any more issues or need further assistance, feel free to ask. I'm here to help! 🤝

mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 13, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 13, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: skeleton This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[joy-ui][Skeleton] When placed over a surface component with color inversion, it gets semi-transparent
3 participants