[docs][joy-ui] Fix color inversion demos #39403
Merged
+62
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
docs
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
@siriwatknp there's this demo here that I added in the previous PR, using color inversion with the styled API. For some reason, the button is not being picked up... can't figure out why, regardless of the markup structure being the same as the other demo using the |
siriwatknp
approved these changes
Oct 12, 2023
|
@siriwatknp can you take a quick look at the comment/demo above?! 😬 👆 |
|
@danilo-leal I found a tiny typescript bug while fixing the demo so I pushed the fix in the latest commit. Let me know if you want me to revert and create another PR. By the way, to use color inversion effectively it should be applied to an array: // sx
- <Box sx={{ …styles, …applyColorInversion('neutral') }}>
+ <Box sx={[{ …styles }, applyColorInversion('neutral')]}>
// styled
- styled('div')({ …styles, …applyColorInversion('neutral') })
+ styled('div')([{ …styles }, applyColorInversion('neutral')]) |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Oct 17, 2023
Co-authored-by: siriwatknp <siriwatkunaporn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some regressions caused by my previous PR on the same page/demos — #39306 🫠
👉 https://deploy-preview-39403--material-ui.netlify.app/joy-ui/main-features/color-inversion/