Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Box] Fix system properties has incorrect Theme interface when applied directly #39404

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

Semigradsky
Copy link
Contributor

Fixes #39402

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@mui-bot
Copy link

mui-bot commented Oct 11, 2023

Netlify deploy preview

https://deploy-preview-39404--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against c6cab59

@zannager zannager added the component: Box The React component. label Oct 12, 2023
@zannager zannager requested a review from mnajdova October 12, 2023 11:43
@ZeeshanTamboli ZeeshanTamboli changed the title fix(Box): Fix BoxOwnProps extending [material-ui][Box] Fix color has incorrect Theme interface Oct 12, 2023
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work typescript package: system Specific to @mui/system package: material-ui Specific to @mui/material labels Oct 12, 2023
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Box] Fix color has incorrect Theme interface [material-ui][Box] Fix system properties has incorrect Theme interface when applied directly Oct 12, 2023
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@ZeeshanTamboli ZeeshanTamboli merged commit 14dd169 into mui:master Oct 12, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 13, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ace when applied directly (mui#39404)
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 13, 2023

Verified

This commit was signed with the committer’s verified signature.
nadine-nguyen Nadine Nguyen
…ace when applied directly (mui#39404)
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 13, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…ace when applied directly (mui#39404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: Box The React component. package: material-ui Specific to @mui/material package: system Specific to @mui/system typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Box] color has incorrect Theme interface
4 participants