Skip to content

[docs-infra] Prevent horizontal scroll in the TOC #39417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Oct 12, 2023

This PR is primarily for adding textOverflow: 'ellipsis' to the table of content items, preventing them from overflowing in case there's a big label without spaces. It's been recently surfaced by a non-related PR (#39412). Also took advantage of the opportunity for some stylistic polish! 😊

👉 https://deploy-preview-39417--material-ui.netlify.app/experiments/docs/data-grid-premium/#css
👉 https://deploy-preview-39417--material-ui.netlify.app/experiments/docs/markdown/#wordwithoutspaceasitwouldhappenwithapropdeclaration

Sorry, something went wrong.

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Oct 12, 2023
@danilo-leal danilo-leal self-assigned this Oct 12, 2023
@mui-bot
Copy link

mui-bot commented Oct 12, 2023

Netlify deploy preview

https://deploy-preview-39417--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against ae2d655

@danilo-leal danilo-leal merged commit ee5083e into mui:master Oct 13, 2023
@danilo-leal danilo-leal deleted the overflow-long-toc-items branch October 13, 2023 11:45
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 17, 2023
@oliviertassinari
Copy link
Member

I guess since it's a TOC, we wouldn't want the word to wrap in that context, sounds fair.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants