Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Table] Bug in "Sorting & Selecting" demo #39426

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

rabeehebrahim
Copy link

@rabeehebrahim rabeehebrahim commented Oct 13, 2023

Closes #39107 - there is a bug in the "Sorting & Selecting" demo with items with the same name.

  • Added id in the createData function and tweaked other functions.

I would like @samuelsycamore to review this PR.

Sorry, something went wrong.

@mui-bot
Copy link

mui-bot commented Oct 13, 2023

Netlify deploy preview

https://deploy-preview-39426--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e8e0af5

@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: table This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Oct 13, 2023
@mapache-salvaje
Copy link
Contributor

Thanks for this @codewithrabeeh ! Please run yarn prettier and yarn docs:typescript:formatted, and then commit the changes to make the CI checks happy. 😁

@rabeehebrahim
Copy link
Author

rabeehebrahim commented Oct 13, 2023

Do you know why running yarn docs:typescript:formatted changes key={row.id} to key={row.name} in components/table/EnhancedTable.js @samuelsycamore

Update:
I solved it. Now you can review this PR.

Copy link
Contributor

@mapache-salvaje mapache-salvaje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, thanks @codewithrabeeh !

@danilo-leal danilo-leal merged commit c9d9713 into mui:master Oct 16, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: table This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Table] Bug in "Sorting & Selecting" demo with items that have the same name
4 participants