[mui-system][style] bug fix for style value check color in nullable object #39457
+9
−99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In PR #39071, we added checks to
getStyleValue
to throw a warning in development mode to double check if the prop value resolved fromthemeMapping
was intentionally object. This was to ensure that setting object values to css such ascolor
does not fail silently. But, the warning was also thrown on setting object values when necessary such as typography tobody1
which quickly led to spam a lot of warnings.Changes Made:
getStyleValue
function to check if the resolved value is non-null object and only throw warning if the object immediately contains color values.getStyleValue
.Testing:
I have updated all relevant tests from the original PR,
style.test.js
,palette.test.js
,styleFunctionsSx.test.js
andTypography.test.js
file to ensure that the changes work as expected. The tests include checking that the warning is only thrown on objects which immediately contain colours.Closes #39399