Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Menu][joy-ui] Fix closing of listbox in MenuList demo #39459

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Oct 15, 2023

fixes: https://mui-org.slack.com/archives/C050VE13HDL/p1696950007321329 Btw issue described in slack only happens on mobile screens.

Before: https://mui.com/joy-ui/react-menu/#menulist-composition

After preview: https://deploy-preview-39459--material-ui.netlify.app/joy-ui/react-menu/#menulist-composition

Before

Screen.Recording.2023-10-15.at.2.56.30.PM.mov

After

Screen.Recording.2023-10-15.at.2.59.10.PM.mov

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
rosstimson-causaly Ross Timson
@sai6855 sai6855 added bug 🐛 Something doesn't work docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy component: select This is the name of the generic UI component, not the React module! labels Oct 15, 2023
@mui-bot
Copy link

mui-bot commented Oct 15, 2023

Netlify deploy preview

https://deploy-preview-39459--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a8359bb

@sai6855 sai6855 requested a review from siriwatknp October 15, 2023 09:38
@mnajdova mnajdova merged commit 96fffe4 into mui:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants