[InputLabel][material-ui] InputLabel supports ownerState.focused for styleOverrides #39470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
component: text field
Netlify deploy previewhttps://deploy-preview-39470--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mj12albert
commented
Oct 16, 2023
Comment on lines
132
to
136
| ...(props.ownerState.focused === true && { | ||
| [`&.${classes.focused}`]: { | ||
| color: colorRed, | ||
| }, | ||
| }), |
There was a problem hiding this comment.
Apparently color isn't the best property to use here as it's the one property that has a specificity conflict with FormLabel: https://github.com/mui/material-ui/blob/master/packages/mui-material/src/FormLabel/FormLabel.js#L47-L49
|
Ported to v6 in #39483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37069, Resolves #36550, Resolves #39427
This PR enables users to more easily customize the
maxWidthof aTextField's label based on it's focused state to control truncation of the labelThe before/after end result look same, but after this fix you are no longer required to manually add a focused state to achieve the customization, and it can be done in the theme
Before: https://codesandbox.io/s/https-github-com-mui-material-ui-issues-39427-vx2gvd?file=/demo.tsx
After: https://codesandbox.io/s/https-github-com-mui-material-ui-pull-39470-y7gr8x