Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I10n] Add Norwegian (nynorsk) (nn-NO) locale #39481

Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 17, 2023

@mui-bot
Copy link

mui-bot commented Oct 17, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9516f11

@zannager zannager added the l10n localization label Oct 17, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit bad8c82 into mui:master Oct 19, 2023
22 of 23 checks passed
@oliviertassinari oliviertassinari added the package: material-ui Specific to @mui/material label Oct 19, 2023
@oliviertassinari oliviertassinari removed the request for review from cherniavskii October 19, 2023 15:44
@oliviertassinari
Copy link
Member

oliviertassinari commented Oct 19, 2023

@ZeeshanTamboli Note that adding this locale is very borderline to the limit we set for a too-high opportunity cost. The concern is that each local has a cost, so has to be worth the effort.

Starting from https://mui.com/material-ui/guides/localization/#supported-locales

Screenshot 2023-10-19 at 16 50 16

We have

Screenshot 2023-10-19 at 16 50 36

https://www.ethnologue.com/insights/ethnologue200/

and

Screenshot 2023-10-19 at 16 51 17

https://w3techs.com/technologies/overview/content_language

I wouldn't be against reverting, but also why not keep it for now, until it becomes an issue? At least, I think it's important when it comes to future language proposals.


Actually, what could be awesome is to

Idea moved to #39525.

@ZeeshanTamboli
Copy link
Member

Starting from https://mui.com/material-ui/guides/localization/#supported-locales

Screenshot 2023-10-19 at 16 50 16

I noticed that statement in our documentation before giving my approval, but I decided to accept this pull request anyway. As you mentioned, I thought, "Why not keep it?" I'll remember this for future language proposals.

@oliviertassinari
Copy link
Member

@ZeeshanTamboli A proposed plan to move forward #39525 (comment). Assuming we can accept x2 more locales than we have today, this PR should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n localization package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants