[zero][vite] Modify plugin to transform node_modules #39517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-39517--material-ui.netlify.app/ Bundle size report |
github-actions
bot
added
the
PR: out-of-date
siriwatknp
reviewed
Oct 20, 2023
| @@ -82,16 +76,19 @@ const cssFunctionTransformerPlugin = declare<BabelPluginOptions>((api, pluginOpt | |||
| if (themeKey === 'typography' && val === 'inherit') { | |||
| return; | |||
| } | |||
| const propertyThemeKey = themeKey ?? val.split('.')[0]; | |||
There was a problem hiding this comment.
Found one more bug. With:
export const Main = styled('main')({
…,
'--test': (props) => props.test,
});produces:
I think the variable should not be created if the result of the callback is undefined | null | ''
There was a problem hiding this comment.
I tried to fix it but I am not sure where to find.
There was a problem hiding this comment.
It'll need to be fixed in styled.ts of zero-runtime package since this function is called at runtime.
Right now it only checks for number/string. It'll need to account for undefined
There was a problem hiding this comment.
Fixed in latest commit.
This feature allows users to specify a list of packages that also uses zero runtime and transform the files at build time. Default behavior is not do transform any files from node_modules.
presence in sxConfig. This did not allow you to write callback functions for css variables.
brijeshb42
force-pushed
the
zero-vite-library
branch
from
37d4ceb
to
376f47a
Compare
github-actions
bot
removed
the
PR: out-of-date
brijeshb42
force-pushed
the
zero-vite-library
branch
2 times, most recently
from
58bf37e
to
3f0e2df
Compare
brijeshb42
force-pushed
the
zero-vite-library
branch
from
3f0e2df
to
e346f8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows users to specify a list of packages
that also uses zero runtime and transform the files at
build time. Default behavior is not transform any files
from node_modules.
Also, fix a bug where the transformation did not allow you to write callback functions for css variables.