[joy-ui][Button] Fix button size being a decorator #39529
Merged
+95
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
component: button
Netlify deploy previewhttps://deploy-preview-39529--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #39515
This is a regression from #38696 because of the increasing of padding-block. I'm fixing it by introducing an internal CSS variable to the button so that the Input can control it.
Before
After
https://codesandbox.io/s/jolly-pine-qf29yc
I use this opportunity to do the same with Select and Textarea.
https://app.argos-ci.com/mui/material-ui/builds/19946/62078137