Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix cut-off sponsors #39572

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 22, 2023

In the current configuration, it feels like the go-to-top floating button will prevent the audience from comfortably clicking on the 3rd diamond sponsor without clicking on he go-to-top and the other way around. I think this PR goes in the right direction, I made only a small change, maybe it should be bolder.

Before https://master--material-ui.netlify.app/material-ui/react-button/#unstyled
Screenshot 2023-10-23 at 00 50 05

After https://deploy-preview-39572--material-ui.netlify.app/material-ui/react-button/#unstyled
Screenshot 2023-10-23 at 00 48 38

A bit related to #39332.

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Oct 22, 2023
@mui-bot
Copy link

mui-bot commented Oct 22, 2023

Netlify deploy preview

https://deploy-preview-39572--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 13bdc79

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me! Just removed the bug label, though — feels more like a fine-tune design change than something that's not working 😬

@oliviertassinari oliviertassinari merged commit 3618a8d into mui:master Oct 24, 2023
23 checks passed
@oliviertassinari oliviertassinari deleted the cut-off-sponsors branch October 24, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants