[docs][joy-ui] Refine the Email, Teams and Files templates #39579
+2,610
−1,337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanivan
added
docs
10 tasks
Netlify deploy previewhttps://deploy-preview-39579--material-ui.netlify.app/ Bundle size report |
danilo-leal
reviewed
Oct 24, 2023
There was a problem hiding this comment.
This is looking great — thanks for taking it!
Overall, I think we can use this PR, or potentially in the next one (?) to standardize some stuff and add new components that weren't available when these templates were first done. Here are some ideas/things I've thought about:
- Add accordions, aspect ratios, snackbars, breadcrumbs, etc.
- Beef up the dummy data a bit to feel a bit more like a real app
- Standardize icon button sizes
- Enhance the template menu a bit — we can make something fancier
- etc.
|
Hey @mnajdova, thanks so much for the help! I'll add a demo for non-modal dialog at the Joy UI docs afterward 🙌 |
|
I am sorry I misclicked 😀 |
siriwatknp
reviewed
Nov 2, 2023
docs/data/joy/getting-started/templates/email/components/WriteEmail.tsx
Outdated
Show resolved
Hide resolved
docs/data/joy/getting-started/templates/email/components/WriteEmail.tsx
Outdated
Show resolved
Hide resolved
docs/data/joy/getting-started/templates/email/components/Mails.tsx
Outdated
Show resolved
Hide resolved
docs/data/joy/getting-started/templates/email/components/EmailContent.tsx
Outdated
Show resolved
Hide resolved
docs/data/joy/getting-started/templates/email/components/EmailContent.tsx
Outdated
Show resolved
Hide resolved
|
Hey @mui/design I'd really appreciate your input on these 😉 Are there any bugs we must fix, or improvements we can add? |
|
@zanivan Can you remove the unused |
1 task
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #38582
Refining the templates, aiming to remove most of the custom styles and overrides, making it as close as possible to the default theme.