[material][styled-engine-sc] Fix ownerstate being propagated to DOM node #39586
+67
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnajdova
added
package: material-ui
Netlify deploy previewhttps://deploy-preview-39586--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
brijeshb42
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #38431 (comment). Starting from v6 styled-components no longer blocks the invalid props used on components created with the styled() util. In 4 of the Material UI components we are using a tag without specifying a slot name for it primitive tag without specifying slot name for it. For all of these components, all props propagated are ending up on the DOM element. This PR adds explicitly a
shouldForwardPropon these places. @siriwatknp we will need to apply the same on Joy UI in cases where we don't have specified slot on the styled component.Previous (search for ownerstate in the DOM inspector): https://codesandbox.io/s/styled-components-forked-pxgs8h?file=/src/demo.js
Now (if it wants to load): https://codesandbox.io/s/styled-components-forked-tjtlgp?file=/src/demo.js