Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joy-ui][docs] Add docs for changing styles based on states #39597

Merged
merged 2 commits into from
Oct 30, 2023
Merged

[joy-ui][docs] Add docs for changing styles based on states #39597

merged 2 commits into from
Oct 30, 2023

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Oct 25, 2023 •
edited by danilo-leal

@siriwatknp siriwatknp added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy customization: theme Centered around the theming features labels Oct 25, 2023
@siriwatknp siriwatknp changed the title add docs override based on state [joy-ui][docs] Add docs for changing styles based on states Oct 25, 2023
@mui-bot
Copy link

mui-bot commented Oct 25, 2023 •
edited

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 馃毇 dangerJS against dce2d68

ZeeshanTamboli
ZeeshanTamboli reviewed Oct 25, 2023
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you don't mind the review; I came across this while looking at the issue.

docs/data/joy/customization/themed-components/themed-components.md Outdated
});
```

The available states are: `active`, `checked`, `completed`, `disabled`, `error`, `expanded`, `focused`, `focusVisible`, `open`, `readOnly`, `required`, `selected`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think open state is available.

docs/data/joy/customization/themed-components/themed-components.md Outdated Show resolved Hide resolved
docs/data/joy/customization/themed-components/themed-components.md Outdated Show resolved Hide resolved
danilo-leal
danilo-leal approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left just some minor comments 馃

docs/data/joy/customization/themed-components/themed-components.md Outdated Show resolved Hide resolved
docs/data/joy/customization/themed-components/themed-components.md Outdated Show resolved Hide resolved
docs/data/joy/customization/themed-components/themed-components.md Outdated Show resolved Hide resolved
@siriwatknp @danilo-leal @ZeeshanTamboli
Apply suggestions from code review
dce2d68 
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Co-authored-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
@siriwatknp siriwatknp merged commit 49b6b7b into mui:master Oct 30, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli left review comments

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees
No one assigned
Labels
customization: theme Centered around the theming features docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs][joy-ui] Provide better documentation on overwriting substyles
4 participants
@siriwatknp @mui-bot @ZeeshanTamboli @danilo-leal