[lab] Remove tree view import from @mui/lab
#39685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
package: lab
Netlify deploy previewhttps://deploy-preview-39685--material-ui.netlify.app/ @material-ui/lab: parsed: -9.48% 😍, gzip: -9.16% 😍 Bundle size reportDetails of bundle changes (Toolpad) |
|
Nice work 👌 Equivalent of #33386 for the pickers Your missing the removal from the theme augmentation (right now we import interfaces that no longer exists) |
flaviendelangle
approved these changes
Nov 3, 2023
michaldudak
reviewed
Nov 3, 2023
| @@ -1,6 +1,6 @@ | |||
| /* eslint-disable @typescript-eslint/no-unused-vars */ | |||
There was a problem hiding this comment.
No idea, I copy what was done in the pickers
The same for why keeping import PropTypes from 'prop-types'; whereas it's not used
michaldudak
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to mui/mui-x#10845