Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Select][joy-ui] Fix displaying placeholder when multiple is true #39806

Merged
merged 5 commits into from
Nov 13, 2023
Merged

[Select][joy-ui] Fix displaying placeholder when multiple is true #39806

merged 5 commits into from
Nov 13, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Nov 8, 2023 •
edited

part of : #39799 (ts bug mentioned in this comment is not fixed in this PR)

missed handling this bug in this PR #39454

@sai6855 sai6855 marked this pull request as draft November 8, 2023 12:58
@sai6855 sai6855 changed the title [Select][joy-ui] [Select][joy-ui] Fix displaying placeholder when multiple is true Nov 8, 2023
@sai6855 sai6855 added bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Nov 8, 2023
@mui-bot
Copy link

mui-bot commented Nov 8, 2023 •
edited

Netlify deploy preview

https://deploy-preview-39806--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 5d1ea15

@sai6855
Refactor Select component to use
6fde261 
renderDisplayValue instead of renderSelectedOption
@sai6855
Refactor
b07614a
mnajdova
mnajdova approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sai6855 sai6855 marked this pull request as ready for review November 8, 2023 13:21
@mnajdova
Update packages/mui-joy/src/Select/Select.tsx
5d1ea15 
Signed-off-by: Marija Najdova <mnajdova@gmail.com>
@mnajdova mnajdova merged commit 20c3ee6 into mui:master Nov 13, 2023
20 checks passed
@sai6855 sai6855 deleted the placeholder-fix branch November 13, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: select This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sai6855 @mui-bot @mnajdova