[core][docs] Remove the "Understand MUI packages" page #39835
Merged
+1
−133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savalaram-redkar
changed the title
Netlify deploy previewhttps://deploy-preview-39835--material-ui.netlify.app/ Bundle size report |
danilo-leal
changed the title
danilo-leal
added
docs
mnajdova
reviewed
Nov 17, 2023
docs/next.config.js
Outdated
| @@ -243,4 +243,13 @@ module.exports = withDocsInfra({ | |||
| { source: `/static/x/:rest*`, destination: 'http://0.0.0.0:3001/static/x/:rest*' }, | |||
| ]; | |||
| }, | |||
| redirects: async () => { | |||
There was a problem hiding this comment.
We keep the redirects in docs/public/_redirects, please remove this and move the redirect entry there.
mnajdova
previously requested changes
Nov 17, 2023
savalaram-redkar
force-pushed
the
core-docs-understanding-mui
branch
from
835d1e3 to
1e0bf3e
Compare
docs/data/material/pages.ts
Outdated
| @@ -185,7 +185,7 @@ const pages: MuiPage[] = [ | |||
| pathname: '/material-ui/guides/creating-themed-components', | |||
| title: 'Creating themed components', | |||
| }, | |||
| { pathname: '/material-ui/guides/understand-mui-packages', title: 'Understand MUI packages' }, | |||
| { pathname: '/blog/mui-product-comparison', title: 'Understand MUI packages' }, | |||
There was a problem hiding this comment.
I think we can remove this line entirely.
There was a problem hiding this comment.
Hey @samuelsycamore, done with the suggested changes. Please take a look into it.
savalaram-redkar
force-pushed
the
core-docs-understanding-mui
branch
from
1e0bf3e to
501d91d
Compare
savalaram-redkar
force-pushed
the
core-docs-understanding-mui
branch
from
501d91d to
bfc02e4
Compare
mapache-salvaje
approved these changes
Nov 27, 2023
github-actions
bot
added
the
PR: out-of-date
1 task
Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
github-actions
bot
removed
the
PR: out-of-date
This comment was marked as resolved.
This comment was marked as resolved.
mapache-salvaje
dismissed
mnajdova’s stale review
Changes have been applied and PR has been approved
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39724
I created a PR with the changes listed below: