-
-
Notifications
You must be signed in to change notification settings - Fork 32.6k
[material][CssVarsProvider] Fix HSL breaking button styles #39869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
@mnajdova @brijeshb42 @siriwatknp this PR is ready for review |
Netlify deploy previewhttps://deploy-preview-39869--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks good to me 👍 However, I wonder if this won't break some apps that depend on the previous logic of the color utils. @siriwatknp what do you think? Maybe tobe safe we can create a new decompose function that we would use in the CssVarsProvider only.
I think the proper fix is to convert We could improve this in the future by replacing all channel tokens with ![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for initiating the fix!
@siriwatknp this is what I meant, I haven't expressed myself clearly :D |
Descriptions
Fixes color breaks when HSL colors is used.
closes #37400
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.