[website] Fix modal not being closed with the escape key on the Base UI page #39880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
changed the title
Netlify deploy previewhttps://deploy-preview-39880--material-ui.netlify.app/ Bundle size report |
danilo-leal
changed the title
michaldudak
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Good catch! No idea why this works this way either...
Perhaps @siriwatknp would know more about this CSS dark magic.
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 30, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38468
I'm uncertain why the transition property
allhad an impact on this.When using
transition: all, the document's activeElement is the "View Modal" button when opened. However, with specific transition properties applied, as in this PR, the document's activeElement becomes the Modal when opened allowing the Escape key to close the modal.While I'm unsure about the reason, it seems to work. I would like to understand why using
transition: alldidn't maintain focus on the modal for allowing closure with the Escape key, or if there's another reason behind it.Before: https://mui.com/base-ui/
After: https://deploy-preview-39880--material-ui.netlify.app/base-ui/
Edit: Also see #38255 (comment).