Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system][Box] Added boxClasses #39896

Merged
merged 3 commits into from
Nov 17, 2023
Merged

[system][Box] Added boxClasses #39896

merged 3 commits into from
Nov 17, 2023
+28 −4

Conversation

sadik-malik
Copy link
Contributor

Added boxClasses for Box component in system #39889

Sorry, something went wrong.

@sadik-malik sadik-malik marked this pull request as ready for review November 16, 2023 16:15
@mui-bot
Copy link

mui-bot commented Nov 16, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39896--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 6777491

@sadik-malik sadik-malik mentioned this pull request Nov 16, 2023
Merged
@zannager zannager requested a review from mnajdova November 16, 2023 17:38
@zannager zannager added package: system Specific to @mui/system component: Box The React component. labels Nov 16, 2023
mnajdova
mnajdova requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should propagate the defaultClassname as boxClasses.root, similar as done in Material UI and Joy UI, otherwise the classname applied on the component will always be MuiBox-root, for e.g. inspect the DOM in https://codesandbox.io/s/angry-blackburn-6m234z?file=/src/Demo.tsx

@sadik-malik
Copy link
Contributor Author

@mnajdova I have made the changes as suggested.

We should propagate the defaultClassname as boxClasses.root, similar as done in Material UI and Joy UI, otherwise the classname applied on the component will always be MuiBox-root, for e.g. inspect the DOM in https://codesandbox.io/s/angry-blackburn-6m234z?file=/src/Demo.tsx

@sadik-malik sadik-malik requested a review from mnajdova November 17, 2023 10:39
mnajdova
mnajdova approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍 Thanks for finish up this effort across all products :)

@mnajdova mnajdova merged commit ba41fda into mui:master Nov 17, 2023
@sadik-malik sadik-malik deleted the system branch November 17, 2023 12:14
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
@sadik-malik @mnajdova
[system][Box] Added boxClasses (mui#39896)
7a36db6
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
@sadik-malik @mnajdova
[system][Box] Added boxClasses (mui#39896)
4dc13b1
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Dec 6, 2023
@sadik-malik @mnajdova
[system][Box] Added boxClasses (mui#39896)
cb6df2d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova

Assignees
No one assigned
Labels
component: Box The React component. package: system Specific to @mui/system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sadik-malik @mui-bot @mnajdova @zannager