[joy-ui][Radio][Input] Fix inheritance of disabled prop #39934
Merged
+52
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-39934--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mnajdova
reviewed
Nov 20, 2023
packages/mui-joy/src/Radio/Radio.tsx
Outdated
| @@ -302,6 +302,7 @@ const Radio = React.forwardRef(function Radio(inProps, ref) { | |||
| const name = inProps.name || radioGroup?.name || nameProp; | |||
| const disableIcon = inProps.disableIcon || radioGroup?.disableIcon || disableIconProp; | |||
| const overlay = inProps.overlay || radioGroup?.overlay || overlayProp; | |||
| const isDisabled = inProps.disabled || formControl?.disabled || disabledProp; | |||
There was a problem hiding this comment.
Suggested change
| const isDisabled = inProps.disabled || formControl?.disabled || disabledProp; | |
| const disabled = inProps.disabled || formControl?.disabled || disabledProp; |
Let's keep disabled as a const name, we never use is as a prefix.
There was a problem hiding this comment.
there is already a variable named disabled, hence went with isDisabled. if not for . I made logic inline like before.isDisabled what do you suggest?
mnajdova
approved these changes
Nov 20, 2023
mnajdova
added
bug 🐛
sai6855
changed the title
Switch, Checkbox,Select were looking good. |
oliviertassinari
added
the
component: text field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
https://codesandbox.io/s/vigorous-leaf-l4ynj3?file=/src/index.tsx
After
https://codesandbox.io/s/elastic-sunset-7fykcs?file=/src/Demo.tsx
In both
InputandRadiodisabledprop from theme were taking precedence overdisabledprop fromFormControl. This PR fixes the issue.