[IconButton][material-next] Copy IconButton to material-next #39945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mj12albert
added
component: icon button
8 tasks
Netlify deploy previewhttps://deploy-preview-39945--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
mj12albert
force-pushed
the
copy-material-next-icon-button
branch
4 times, most recently
from
7e4034c
to
def1505
Compare
mj12albert
commented
Nov 22, 2023
Comment on lines
+8
to
+9
| import ButtonBase from '@mui/material/ButtonBase'; | ||
| import { iconButtonClasses as classes } from '@mui/material/IconButton'; |
There was a problem hiding this comment.
Importing these from material-next right now now will fail most of the tests because of focusRipple being dropped from ButtonBase, easier to keep them as-is instead of adding .skip() to a bunch of tests
mj12albert
commented
Nov 22, 2023
| import { alpha } from '@mui/system'; | ||
| import styled from '../styles/styled'; | ||
| import useThemeProps from '../styles/useThemeProps'; | ||
| import ButtonBase from '../ButtonBase'; |
There was a problem hiding this comment.
Also cannot import from material-next yet due to focusRipple
mj12albert
force-pushed
the
copy-material-next-icon-button
branch
from
def1505
to
697c5d1
Compare
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 30, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #39943
This PR copies
IconButtontomaterial-nextwith minimal changes