-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Show design links on Joy UI #39955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
Improvements or additions to the documentation
design: joy
This is about Joy Design, please involve a visual or UX designer in the process
labels
Nov 21, 2023
danilo-leal
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good one! Thanks for picking it up — it fell off my radar! Left a tiny copy tweak to make the writing lint happy 😬
Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com> Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 30, 2023
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 1, 2023
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design: joy
This is about Joy Design, please involve a visual or UX designer in the process
docs
Improvements or additions to the documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have these components covered in Joy UI now: https://www.figma.com/community/file/1293288155415213351
Preview: https://deploy-preview-39955--material-ui.netlify.app/joy-ui/react-alert/.
I have worked a bit on this because Joy UI Figma file downloads are so low, no designers/developers seem to care
https://docs.google.com/spreadsheets/d/1BXZQmzVCzSkzyOedSnRtG_1gInU-_--Z-jSZNYjAE2k/edit#gid=0
So I'm working on bringing Joy UI exposure to the same level as Material UI. This allows us to compare apple to apple. We will know more about either the issue is intrinsic to Joy Design it's idea, it's execution, etc. Effectively, I want to remove a lack of proper exposure as one of the possible reasons.