[joy-ui][Badge] Shouldn't crash when using custom size #39986
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saumya Pandey <pandeyysaumya@gmail.com>
Signed-off-by: Saumya Pandey <pandeyysaumya@gmail.com>
iamsaumya
changed the title
Netlify deploy previewhttps://deploy-preview-39986--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
danilo-leal
added
component: badge
|
Could you please create a new issue first and provide a CodeSandbox reproduction of the problem you're encountering? You can use this template for the CodeSandbox. |
|
Since there is no response on the above comment, I am closing it. |
|
Here is the codesandbox link https://codesandbox.io/p/sandbox/epic-kate-rlxhwy |
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
@iamsaumya I made the changes. Thanks for your contribution!
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jan 9, 2024
Signed-off-by: Saumya Pandey <pandeyysaumya@gmail.com> Co-authored-by: ZeeshanTamboli <zeeshan.tamboli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need additional size for Badge component and don't have corresponding
body-<>level for itBefore: https://codesandbox.io/p/sandbox/festive-swanson-8mt9l6?file=%2Fsrc%2FApp.tsx%3A2%2C16
After: https://codesandbox.io/p/sandbox/joy-ui-cra-ts-forked-2sp3rh?file=%2Fsrc%2FApp.tsx%3A21%2C1