[joy-ui] Address TypeScript issue with custom zIndex not functioning #40133
+24
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40133--material-ui.netlify.app/ Bundle size report |
ZeeshanTamboli
changed the title
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
requested changes
Dec 14, 2023
There was a problem hiding this comment.
Thanks for the pull request to address this. However, fixing the issue requires more than just this change. Primarily, you need to export it from packages/mui-joy/src/styles/index.ts. Additionally, for testing, please include a TypeScript module augmentation test in packages/mui-joy/test/typescript/moduleAugmentation.
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
@qiweiii I have made the expected changes. Thanks for your contribution!
|
Oh thanks, I have missed my email notification, didn't see your previous comment... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40092
Before: https://codesandbox.io/p/sandbox/eloquent-boyd-56rhsv?file=%2Fsrc%2FApp.tsx%3A8%2C2
After: https://codesandbox.io/p/sandbox/joy-ui-cra-ts-forked-lr2xw5?file=%2Fsrc%2FApp.tsx%3A12%2C18