Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs][Popper] Update Positioned Popper demo styles #40170

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Dec 10, 2023

This PR places content of Popper above drawer so that text inside popper is clearly visible

preview: https://deploy-preview-40170--material-ui.netlify.app/material-ui/react-popper/#positioned-popper

Before

Screenshot 2023-12-10 at 12 00 15 PM

After

Screenshot 2023-12-10 at 12 19 12 PM

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@sai6855 sai6855 added docs Improvements or additions to the documentation component: Popper The React component. See <Popup> for the latest version. enhancement This is not a bug, nor a new feature labels Dec 10, 2023
@sai6855 sai6855 marked this pull request as draft December 10, 2023 06:31
@mui-bot
Copy link

mui-bot commented Dec 10, 2023

Netlify deploy preview

https://deploy-preview-40170--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e215e8f

<Popper open={open} anchorEl={anchorEl} placement={placement} transition>
<Popper
// Note: The following zIndex style is specifically for documentation purposes and may not be necessary in your code.
sx={{ zIndex: 1200 }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried zIndex value from 100 to 1200, seems like from 1200 it started to working

@sai6855 sai6855 marked this pull request as ready for review December 10, 2023 09:16
@mapache-salvaje mapache-salvaje changed the title [materia-ui][docs][Popper] Update Positioned Popper demo styles [material-ui][docs][Popper] Update Positioned Popper demo styles Dec 11, 2023
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Signed-off-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
@danilo-leal danilo-leal added the package: material-ui Specific to @mui/material label Dec 11, 2023
@danilo-leal danilo-leal merged commit 7f27b54 into mui:master Dec 11, 2023
@sai6855 sai6855 deleted the popper-zindex branch December 11, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Popper The React component. See <Popup> for the latest version. docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants