Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui] Use direct import from utils package #40254

Merged
merged 10 commits into from
Dec 20, 2023
Merged

[material-ui] Use direct import from utils package #40254

merged 10 commits into from
Dec 20, 2023
+265 −265

Conversation

siriwatknp
Copy link
Member

closes #40251

Sorry, something went wrong.

@siriwatknp
temp: create temp codemod

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
5239e82
@siriwatknp
refactor import to use direct module

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
eb5bf60
@siriwatknp
Revert "temp: create temp codemod"

Verified

This commit was signed with the committer’s verified signature.
nadine-nguyen Nadine Nguyen
SSH Key Fingerprint: vhgmubL/4wUb78heZVh7hFafYrs3xW0RAAysoDI9c2A
Verified
Learn about vigilant mode
ab72190 
This reverts commit 5239e82.
@siriwatknp
Revert "Revert "temp: create temp codemod""

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
11d83af 
This reverts commit ab72190.
@siriwatknp
fix lab import
6d3646b
@siriwatknp
Revert "Revert "Revert "temp: create temp codemod"""
eae4445 
This reverts commit 11d83af.
@siriwatknp siriwatknp added package: material-ui Specific to @mui/material enhancement This is not a bug, nor a new feature labels Dec 20, 2023
@mui-bot
Copy link

mui-bot commented Dec 20, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-40254--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a8edc07

@siriwatknp siriwatknp merged commit 7c2f0ca into mui:master Dec 20, 2023
@MonstraG MonstraG mentioned this pull request Dec 22, 2023
Closed
1 task
@michaldudak
Copy link
Member

michaldudak commented Dec 27, 2023 •
edited
Loading

The changes in @mui/lab and @mui/material-next look OK, but since we define the local generateUtilityClass and generateUtilityClasses in @mui/material, I'd say that we should use them instead of the @mui/utils version. It will let Material UI components use any changes that we apply to these local versions of these functions (as in Base UI: https://github.com/mui/material-ui/pull/40205/files#diff-a17528d1b9882dbc6751ebe40512d5e02800c36168153e4161269c2fbd8a0399).
There was a PR open that implemented it: #39878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brijeshb42 brijeshb42

Assignees
No one assigned
Labels
enhancement This is not a bug, nor a new feature package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[material-ui] Use direct import from utils package
4 participants
@siriwatknp @mui-bot @michaldudak @brijeshb42