[code-infra] Extract Babel macro from mui-utils

[michaldudak]

I moved the MuiError Babel macro to its own package, so @mui/utils contain only run-time (not build-time logic).

This is necessary for the pnpm migration, as we would like to link build outputs between workspace projects (as opposed to sources, like it's done today). Bundlers and other tools will use Babel/Webpack/TS aliases to resolve the sources, but it was proven to be problematic in the case of the macro (somehow aliases did not apply there).

[mui-bot]

Netlify deploy preview

https://deploy-preview-40262--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 721d200

[Janpot]

This feels like an improvement as well.

I think there is a test somewhere that checks whether these macro imports appear in the build output, at which point it errors. Does that still work? (I may be hallucinating this)

[michaldudak]

I think there is a test somewhere that checks whether these macro imports appear in the build output

I haven't found anything like this (I checked all occurrences of "macro" and "MuiError" in the codebase).

[michaldudak]

@mui/x, I found one reference to the macro: https://github.dev/mui/mui-x/blob/d7149efe21b3b43f76fbf65aa35c499a7861d590/docs/babel.config.js#L41
I don't quite understand why it replaces the macro import with react, but I created a PR that updates the path: mui/mui-x#11479

[flaviendelangle]

😆 Wow this replacement is weird, no idea why it's here

[flaviendelangle]

Found its source: mui/mui-x@7cab049#diff-2ed4f5b03d34a87ef641e9e36af4a98a1c0ddaf74d07ce93665957be69b7b09a

[michaldudak]

Unfortunately, there's no word of explanation.

[flaviendelangle]

🤷 Yes, it's a mistery

[Janpot]

Yep, we had this in Toolpad for a while after copying the setup from X. I remember asking @oliviertassinari about it once. I couldn't figure out what the sense in it was so I removed it on our side. I'd say remove it, and if that breaks something let's figure out a better solution.

[oliviertassinari]

As I recall about this, the idea was to have an import that works, I used react as I could have used something random, I assumed errors will normally not throw.