[utils] Centralize clamp implementation in utils #40267
Merged
+57
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-40267--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
@Kamino0 If you look at the CI, the tests fail related to the Slider. Can you take a look?
added 2 commits
December 28, 2023 00:17
mj12albert
reviewed
Dec 28, 2023
mj12albert
previously requested changes
Dec 28, 2023
There was a problem hiding this comment.
@Kamino0 Thanks for working on this 🤚 looks good, I have suggested one change ~
ZeeshanTamboli
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
@Kamino0 I pushed the requested changes. Thank you for your contribution!
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update unify clamp functions and move it to utils as suggested in #39365