Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Fix broken links in the All components page #40303

Merged
merged 4 commits into from
Dec 24, 2023
Merged

[material-ui][docs] Fix broken links in the All components page #40303

merged 4 commits into from
Dec 24, 2023

Conversation

muazaqdas
Copy link
Contributor

@muazaqdas muazaqdas commented Dec 24, 2023

Fix #40298

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…s.js

Corrected the link of bottom navigation component.

Signed-off-by: Muaz Aqdas <84477094+muazaqdas@users.noreply.github.com>
@mui-bot
Copy link

mui-bot commented Dec 24, 2023

Netlify deploy preview

https://deploy-preview-40303--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 332d534

@oliviertassinari oliviertassinari changed the title fix: the getway to bottom navigatio is broken #40298 [docs] Fix link to bottom navigation Dec 24, 2023
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work docs Improvements or additions to the documentation labels Dec 24, 2023
@muazaqdas
Copy link
Contributor Author

Why did argos check failed earlier?

@danilo-leal danilo-leal changed the title [docs] Fix link to bottom navigation [material-ui][docs] Fix broken links in the All components page Dec 24, 2023
@danilo-leal danilo-leal added the package: material-ui Specific to @mui/material label Dec 24, 2023
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you & Merry Christmas! 🎄
Missed these ones on my initial PR for the All Components page. 😬

@muazaqdas
Copy link
Contributor Author

muazaqdas commented Dec 24, 2023

Thank you & Merry Christmas! 🎄 Missed these ones on my initial PR for the All Components page. 😬

Most Welcome. It was my first PR in MUI and my second open source contribution, so thank you for the opportunity. 🤓
Hope you have a lovely day. 😊

@danilo-leal danilo-leal merged commit f57e7d2 into mui:master Dec 24, 2023
@muazaqdas muazaqdas deleted the fix/getway_to_bottom_navigatio branch December 24, 2023 21:23
@muazaqdas muazaqdas restored the fix/getway_to_bottom_navigatio branch December 24, 2023 21:25
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024
…40303)

Co-authored-by: Danilo Leal <67129314+danilo-leal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui] Broken links in the All components page
4 participants