Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blog] Update open-graph cards for all posts #40328

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

danilo-leal
Copy link
Contributor

This PR makes sure every blog post up until now has card: true. In addition, I updated all of the posts that use the standard "title + authors" card, ensuring they share the latest design styles. They're all available on this Figma file (available for MUI org members only).

I also compressed the images as much as I could, but I'm not sure if their size is too big.
@oliviertassinari would appreciate a double-check here!

Sorry, something went wrong.

@mui-bot
Copy link

mui-bot commented Dec 26, 2023

Netlify deploy preview

https://deploy-preview-40328--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 164bbc6

@oliviertassinari
Copy link
Member

Nice, love seeing this.

I dream of a world where we can automate all of those generations with https://www.notion.so/mui-org/Page-image-generator-og-image-75bc177fefe64c0b899a42a6f919a907

@danilo-leal
Copy link
Contributor Author

Me too; it's a somewhat tedious process, I won't lie. 😅

Verified

This commit was signed with the committer’s verified signature.
oliviertassinari Olivier Tassinari

Verified

This commit was signed with the committer’s verified signature.
oliviertassinari Olivier Tassinari
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 👍

@danilo-leal
Copy link
Contributor Author

@oliviertassinari, I'd appreciate an approval here so I can merge it! :)

@danilo-leal danilo-leal merged commit 88b2273 into mui:master Dec 27, 2023
@danilo-leal danilo-leal deleted the update-blog-post-og-cards branch December 27, 2023 00:53
@oliviertassinari oliviertassinari added the design This is about UI or UX design, please involve a designer label Dec 27, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Jan 9, 2024

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blog design This is about UI or UX design, please involve a designer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants