[joy-ui][RadioGroup] Allow zero number as a value #40344
Merged
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for this change is that the Radio component didn't work when there was a value of 0 since !!0 => false, this way we explicitly check for undefined/null.
2 tasks
Netlify deploy previewhttps://deploy-preview-40344--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
aacevski
changed the title
danilo-leal
changed the title
danilo-leal
added
component: radio
siriwatknp
reviewed
Jan 3, 2024
…eck the initial value of Radio
Yep, just added two tests - one is for the initial value and one to check the value when clicking on the Radio elements. 🙌🏼 I also made sure to check if the tests failed with the old code, and they did. |
ZeeshanTamboli
changed the title
ZeeshanTamboli
changed the title
ZeeshanTamboli
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this change is that the Radio component didn't work when there was a value of 0 since !!0 => false, this way we explicitly check for undefined/null.
Closes: #40342
Before: https://stackblitz.com/edit/react-cs6xw6?file=Demo.tsx
After: https://codesandbox.io/p/sandbox/joy-ui-cra-ts-forked-pjnwf8?file=%2Fsrc%2FApp.tsx%3A25%2C1