[system] Fix all use of styled(Box) #40449
Merged
+155
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
package: system
Netlify deploy previewhttps://deploy-preview-40449--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
no-styled-box
branch
2 times, most recently
from
5253853 to
bd91b76
Compare
oliviertassinari
force-pushed
the
no-styled-box
branch
from
bd91b76 to
c7fc70f
Compare
oliviertassinari
force-pushed
the
no-styled-box
branch
from
be42fb1 to
9d3a21b
Compare
brijeshb42
approved these changes
Jan 8, 2024
oliviertassinari
commented
Jan 8, 2024
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Jan 9, 2024
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I saw while reviewing https://app.ashbyhq.com/jobs/ee40c71f-2807-4235-a73f-76a397a1e661/candidate-pipeline/active/right-side/candidates/76bcaaf9-3644-497a-b93c-3230b5119b26/applications/331a983d-10a0-4459-b417-ea76bb29aa96/feed.
We exclusively use the
sxprop to style with Box, we don't use the flattened prop https://mui.com/system/react-box/#system-props in our codebase (I would be more than happy to deprecate this). So it doesn't make much sense to me to have styled(Box). It's not good for performance.