[core] Simplify server detection #40471
Merged
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
fix-server-detection
branch
2 times, most recently
from
af93375 to
59294c9
Compare
Netlify deploy previewhttps://deploy-preview-40471--material-ui.netlify.app/ Bundle size report |
oliviertassinari
changed the title
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
fix-server-detection
branch
from
59294c9 to
72063ea
Compare
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this in https://github.com/mui/material-ui/pull/40436/files#diff-1a789c7102503b05ee999e6b5919f0bb7ed66eda5ca272d88ee3e40f8288dff2R3. I think it's best to stick to a single API throughout MUI's codebase.
This is a detail though. I don't expect meaningful outcomes from this PR other than making it easier to search in the codebase these instances.