[docs-infra] Update the outlined Demo container dark mode color #40488
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilo-leal
added
design
Netlify deploy previewhttps://deploy-preview-40488--material-ui.netlify.app/ Bundle size report |
|
Does the preview page work?
Chip bg is still invisible to me. If I zoom in to like 200% then I can barely see it |
|
Hey, that's a good one for consistency! However, I wonder if we could use a transparent background on the demo container like we do for the light theme, this would increase the contrast a bit more, and also would improve the consistency :) |
danilo-leal
changed the title
danilo-leal
changed the title
zanivan
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the outlined Demo container for Joy UI components to match the styles we use for Material UI (general docs consistency). Additionally, this should close #40472 given a slightly darker container will be able to showcase how the chip does have a background.
https://deploy-preview-40488--material-ui.netlify.app/joy-ui/react-chip/#basic-usage