Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Rating] Fix rating width via min-content #40503

Merged
merged 9 commits into from
Jan 20, 2024
Merged

[material-ui][Rating] Fix rating width via min-content #40503

merged 9 commits into from
Jan 20, 2024
+1 −0

Conversation

devhik0
Copy link
Contributor

@devhik0 devhik0 commented Jan 9, 2024

Closes: #40371

Sorry, something went wrong.

@devhik0
fix: rating width via min-content

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
GPG key ID: 1B38D43B1E40326D
Verified
Learn about vigilant mode
ac4c890
@mui-bot
Copy link

mui-bot commented Jan 9, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-40503--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 81033b6

@danilo-leal danilo-leal changed the title [material-ui][Rating]Fix rating width via min-content [material-ui][Rating] Fix rating width via min-content Jan 10, 2024
@danilo-leal danilo-leal added package: material-ui Specific to @mui/material component: rating This is the name of the generic UI component, not the React module! labels Jan 10, 2024
@zannager zannager requested a review from michaldudak January 10, 2024 13:15
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 17, 2024
devhik0 and others added 3 commits January 18, 2024 02:00
@devhik0
fix: rating width via min-content

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
GPG key ID: 1B38D43B1E40326D
Verified
Learn about vigilant mode
7373b63
@devhik0
Merge branch 'fix-rating-width' of https://github.com/devhik0/materia…

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
GPG key ID: 1B38D43B1E40326D
Verified
Learn about vigilant mode
71478a1 
…l-ui into fix-rating-width
@devhik0
Merge branch 'master' into fix-rating-width

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
GPG key ID: 1B38D43B1E40326D
Verified
Learn about vigilant mode
77934e8 
Signed-off-by: devhiko <151969082+devhik0@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 18, 2024
@devhik0
fix conflict

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
GPG key ID: 1B38D43B1E40326D
Verified
Learn about vigilant mode
b4c0ecf
@devhik0 devhik0 requested a review from michaldudak January 18, 2024 21:39
@devhik0
Merge branch 'master' of https://github.com/mui/material-ui into fix-…

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
GPG key ID: 1B38D43B1E40326D
Verified
Learn about vigilant mode
4bc7f47 
…rating-width
@devhik0
sync fork

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
GPG key ID: 1B38D43B1E40326D
Verified
Learn about vigilant mode
58cfb10
@ZeeshanTamboli
revert unnecessary diff

Verified

This commit was signed with the committer’s verified signature.
sentrivana Ivana Kellyer
GPG key ID: 1B38D43B1E40326D
Verified
Learn about vigilant mode
820f5e2
@ZeeshanTamboli
Merge branch 'master' into fix-rating-width

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
81033b6
@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label Jan 20, 2024
ZeeshanTamboli
ZeeshanTamboli approved these changes Jan 20, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ZeeshanTamboli ZeeshanTamboli merged commit 6f955d3 into mui:master Jan 20, 2024
@devhik0
Copy link
Contributor Author

devhik0 commented Jan 20, 2024

Thanks, really appreciate it

@devhik0 devhik0 deleted the fix-rating-width branch January 20, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli

@michaldudak michaldudak

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: rating This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[material-ui][Rating] Sizes demo not working as expected
5 participants
@devhik0 @mui-bot @michaldudak @ZeeshanTamboli @danilo-leal