-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs-infra] Enforce brand name rules #40525
Conversation
Netlify deploy previewhttps://deploy-preview-40525--material-ui.netlify.app/ Bundle size report |
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com> Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Next, I think we should:
|
I don't know how it react with the setting If installed I tend to disable all other rules, and then run the next command to verify if I missed some fixed
|
I guess we can enable https://github.com/errata-ai/vale-action?tab=readme-ov-file#fail_on_error-default-false |
@alexfauquette It fails the CI, perfect. We forgot MUI Core, MUI Store, MUI Toolpad, MUI Connect, adding to the list: |
This is a continuation of mui/mui-x#11645 (comment). See how annoying it is when a non-breaking space is missed with MUI X. That line breaks in the middle 🙈. The other objective is to flag all the cases where we use MUI. In 80% of the time, this shouldn't happen in the first place.
This seems to work:
Screen.Recording.2024-01-16.at.01.52.26.mov