[docs][joy-ui] Move tutorial to iframe #40567
Merged
+58
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewBundle size report |
oliviertassinari
force-pushed
the
joy-iframe
branch
from
165efc0 to
16aa6ed
Compare
Comment on lines
20
to
23
| if (!mounted) { | ||
| return null; | ||
| return <Button variant="soft">Change mode</Button>; | ||
| } |
There was a problem hiding this comment.
Solve layout shift, annoying.
| @@ -35,59 +35,56 @@ function ModeToggle() { | |||
|
|
|||
| export default function LoginFinal() { | |||
| return ( | |||
| <CssVarsProvider> | |||
There was a problem hiding this comment.
This is duplicated, global styles are injected twice in the page, creating mess in the dev tools to debug.
| Don't have an account? | ||
| <main> | ||
| <ModeToggle /> | ||
| <CssBaseline /> |
There was a problem hiding this comment.
This was missing, not following the docs. I noticed because the export to codesandbox wouldn't look the same as in the iframe.
Comment on lines
431
to
438
| if (demoOptions.bg == null) { | ||
| demoOptions.bg = 'outlined'; | ||
| } | ||
|
|
||
| if (demoOptions.iframe) { | ||
| demoOptions.bg = true; | ||
| if (demoOptions.iframe) { | ||
| demoOptions.bg = true; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
A Docs-infra bug, even if we set a default background for iframe different than for non-iframe demos, we should still be able to customize it.
| {{"demo": "LoginFinal.js"}} | ||
| {{"demo": "LoginFinal.js", "iframe": true, "height": 500, "bg": "outlined"}} |
There was a problem hiding this comment.
This demo shows a full page. I believe it makes more sense to isolate the code in an iframe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mui.com/joy-ui/getting-started/tutorial/#interactive-demo has a couple of issues that this PR fix.