[docs-infra] Minimize ad layout shift on mobile #40582
Merged
+32
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-40582--material-ui.netlify.app/ Bundle size report |
oliviertassinari
force-pushed
the
docs-infra-ad-layout-shift
branch
2 times, most recently
from
1c9e039 to
214e3c4
Compare
oliviertassinari
force-pushed
the
docs-infra-ad-layout-shift
branch
from
214e3c4 to
1a1135d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was annoyed by this today while browsing the docs on my phone. This layout shift is not fun:
Screen.Recording.2024-01-14.at.01.56.10.mov
After, the layout shift can still happen (for the longest possible ad descriptions), but it's a lot less likely:
Screen.Recording.2024-01-14.at.01.55.20.mov
https://deploy-preview-40582--material-ui.netlify.app/material-ui/react-checkbox/