Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utils] Remove unnecessary default export #40788

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jan 26, 2024

Got this warning when building zero demo next-app

../../packages/mui-utils/build/esm/scrollLeft/index.js
export 'default' (reexported as 'default') was not found in './scrollLeft' (possible exports: detectScrollType, getNormalizedScrollLeft)

It turns out that the scrollLeft.ts does not have default export but the index file try to do it.

Sorry, something went wrong.

@siriwatknp siriwatknp requested a review from mnajdova January 26, 2024 07:06
@siriwatknp siriwatknp added package: utils Specific to the @mui/utils package enhancement This is not a bug, nor a new feature labels Jan 26, 2024
@mui-bot
Copy link

mui-bot commented Jan 26, 2024

Netlify deploy preview

https://deploy-preview-40788--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 9f5cfde

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@siriwatknp siriwatknp merged commit 07927e0 into mui:master Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature package: utils Specific to the @mui/utils package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants