[material-ui][avatar] Add props deprecation with a codemod #40853
Conversation
siriwatknp
added
package: material-ui
siriwatknp
added
component: avatar
Netlify deploy preview@material-ui/lab: parsed: +0.37% , gzip: +0.38% Bundle size reportDetails of bundle changes (Toolpad) |
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
github-actions
bot
added
PR: out-of-date
Signed-off-by: Siriwat K <siriwatkunaporn@gmail.com>
github-actions
bot
removed
the
PR: out-of-date
…ecation/avatar-props
|
@DiegoAndai I adjust the migration doc format a bit to start with codemod because I think that's what the majority of users are looking for. |
github-actions
bot
added
the
PR: out-of-date
docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
Outdated
Show resolved
Hide resolved
| const root = j(file.source); | ||
| const printOptions = options.printOptions; | ||
|
|
||
| findComponentJSX(j, { root, componentName: 'Avatar' }, (elementPath) => { |
There was a problem hiding this comment.
We should look into an abstraction for the slot pattern standardization codemods, as all will be pretty similar. It doesn't need to happen now, we can wait until we have a couple more.
| }); | ||
| }); | ||
|
|
||
| root.find(j.ImportDeclaration, { source: { value: '@mui/material' } }).forEach((path) => { |
There was a problem hiding this comment.
Isn't @mui/material covered above?
Thanks! can you rebase and do the same for the recently added Divider one? |
github-actions
bot
removed
the
PR: out-of-date
|
|
||
| /** | ||
| * @param {import('jscodeshift').FileInfo} file | ||
| * @param {import('jscodeshift').API} api | ||
| */ | ||
| export default function deprecationsAll(file, api, options) { | ||
| file.source = transformAccordionProps(file, api, options); | ||
| file.source = transformAvatarProps(file, api, options); | ||
| file.source = transformDividerProps(file, api, options); |
There was a problem hiding this comment.
@DiegoAndai For completeness, I added divider transform here. Let me know if this is okay to you, otherwise I will open a separate PR.
There was a problem hiding this comment.
That's perfect, we missed it 😅
docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
Outdated
Show resolved
Hide resolved
docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
Outdated
Show resolved
Hide resolved
docs/data/material/migration/migrating-from-deprecated-apis/migrating-from-deprecated-apis.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Diego Andai <diego@mui.com>
Part of #40417