New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[joy-ui][IconButton] Support loading
prop
#40949
[joy-ui][IconButton] Support loading
prop
#40949
Conversation
Netlify deploy previewhttps://deploy-preview-40949--material-ui.netlify.app/ @mui/joy: parsed: +0.17% , gzip: +0.20% Bundle size reportDetails of bundle changes (Toolpad) |
340fc29
to
420c3a1
Compare
385d7b0
to
a64e138
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Smileek, thanks for the pull request.
In the meantime, fixed a bug in the Button component:
ButtonGroup's
disabled
prop wasn't overridden, because the first part of(inProps.disabled || inProps.loading) ?? (buttonGroup.disabled || disabledProp || loading);
resulted in(false || undefined)
which isundefined
.
Could you address this in a separate PR and undo the changes related to this in the current PR?
Before reviewing the code, could you explain your use case for needing this feature? Is it necessary for your application?
loading
prop
a64e138
to
8f8ec84
Compare
@ZeeshanTamboli sure. Here's another one: #41000 |
Thanks for that pull request. I have reviewed it. |
8f8ec84
to
a4703b5
Compare
@ZeeshanTamboli thanks for the review, everything is fixed: a4703b5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Smileek Thanks for your contribution!
This closes #36692
Mostly stolen from the Button component, but seemed to be a good task to start getting to know the project.