New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui] Refine checkout template #40967
Conversation
Netlify deploy previewhttps://deploy-preview-40967--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting there! Large review but mostly details. Also, heads-up to add theme customizations to the Alert component (that's too Material Design-y on the custom theme!)
docs/data/material/getting-started/templates/checkout/ToggleColorMode.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/PaymentForm.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/PaymentForm.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/PaymentForm.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/PaymentForm.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/getCheckoutTheme.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/getCheckoutTheme.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/getCheckoutTheme.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/getCheckoutTheme.tsx
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/getCheckoutTheme.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Excited to have this one out, too — further improvements can come iteratively, in my perspective 🤙 And thanks for being so welcoming with the extensive feedback! 🙏
docs/data/material/getting-started/templates/checkout/Review.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/Review.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/PaymentForm.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/PaymentForm.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/PaymentForm.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/Checkout.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/Checkout.tsx
Outdated
Show resolved
Hide resolved
docs/data/material/getting-started/templates/checkout/Checkout.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DiegoAndai I think this is ready for the engineering review 🙌 Would you mind giving me a hand with the failing tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DiegoAndai this file was created by docs:typescript:formatted
, but I don't it's necessary. However, the tests fail when this file is not committed—what could be done then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird 🤔 InfoMobile.tsx
is the only file this is happening with? It looks like it's mistaking it for a docs demo. @mnajdova would you know anything about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should only create preview files for the demos, not templates. I will look into updating the script. It was likely generated only for this file because there render is short (less than 15 lines of code I think was the minimum :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀
Is the regression test failing consistently?
For the regression test failure, we need to exclude the We have to do this for all non-component files: #37557 (comment) |
Part of #37555 / Closes #41098
This PR is for refining the checkout template to be aligned with the new landing page template.
👉 https://deploy-preview-40967--material-ui.netlify.app/material-ui/getting-started/templates/checkout/
Note
The thumbnails and template's information will be updated last