Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Export functions from copyFiles script to reuse in MUI X repo #40970

Merged

Conversation

cherniavskii
Copy link
Member

In MUI X we use a slightly modified copy of copyFiles script https://github.com/mui/mui-x/blob/next/scripts/copyFiles.mjs
We can easily reuse a large chunk of the file by importing functions that are identical.

@cherniavskii cherniavskii added the core Infrastructure work going on behind the scenes label Feb 6, 2024
@mui-bot
Copy link

mui-bot commented Feb 6, 2024

Netlify deploy preview

https://deploy-preview-40970--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 224129e

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe before merging test on locale that you're able to do the modification you want on X with this branch ;)

@cherniavskii
Copy link
Member Author

Tested it locally:

  • yarn release:build
  • remove build folders from .gitignore and temporarily commit the files in build folders
  • update copyFiles to use functions from copyFilesUtils from monorepo
  • yarn release:build
  • No diffs for the files in build folders

@cherniavskii cherniavskii merged commit 97bd4c7 into mui:master Feb 8, 2024
19 checks passed
@cherniavskii cherniavskii deleted the export-functions-from-copyFiles branch February 8, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants