[joy-ui][Button] Fix disabled prop priority when inside button group
#41000
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-41000--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
1 task
danilo-leal
changed the title
disabled prop prioritydisabled prop priority
danilo-leal
added
component: button
ZeeshanTamboli
added
bug 🐛
ZeeshanTamboli
changed the title
disabled prop prioritydisabled prop priority when inside button grup
ZeeshanTamboli
changed the title
disabled prop priority when inside button grupdisabled prop priority when inside button group
|
Also, it's a regression from #38673. |
Signed-off-by: Zeeshan Tamboli <zeeshan.tamboli@gmail.com>
Smileek
force-pushed
the
smileek/fix-button-disabled-prop
branch
from
f228a0f to
e9d460d
Compare
ZeeshanTamboli
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug in the Button component:
ButtonGroup's
disabledprop wasn't overridden, because the first part of(inProps.disabled || inProps.loading) ?? (buttonGroup.disabled || disabledProp || loading);resulted in(false || undefined)which isundefined.The correct order is
(inProps.loading || inProps.disabled), because if it's loading, we should always disable a button. If it's not (whetherfalseorundefined), we should rely ondisabledprop which could betrue,falseorundefinedand make the whole construction work properly.