Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infra] Adjust the links to search for issues #41008

Merged
merged 4 commits into from
Mar 1, 2024
Merged

[infra] Adjust the links to search for issues #41008

merged 4 commits into from
Mar 1, 2024
+10 −10

Conversation

michelengelen
Copy link
Member

In accordance to mui/mui-x#11995

Quote from the linked PR:

I noticed that the link in the issues templates leads to the default issue search, which looks for is:issue and is:open. Since the solution could also be in a closed issue this should be adjusted.

Sorry, something went wrong.

@michelengelen
adjusted the links to the issue search to include closed issues as well

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
c13aa6f
@michelengelen michelengelen added the core Infrastructure work going on behind the scenes label Feb 8, 2024
@michelengelen michelengelen self-assigned this Feb 8, 2024
@mui-bot
Copy link

mui-bot commented Feb 8, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against a33fd78

@oliviertassinari oliviertassinari changed the title [infra] Adjusted issue search links [infra] Adjust issue search links Feb 8, 2024
@oliviertassinari oliviertassinari changed the title [infra] Adjust issue search links [infra] Adjust the links to search for issues Feb 8, 2024
@oliviertassinari oliviertassinari removed their request for review February 8, 2024 17:56
@oliviertassinari oliviertassinari changed the title [infra] Adjust the links to search for issues [core] Adjust the links to search for issues Feb 8, 2024
@oliviertassinari oliviertassinari changed the title [core] Adjust the links to search for issues [infra] Adjust the links to search for issues Feb 8, 2024
@oliviertassinari oliviertassinari added the scope: infra Org infrastructure work going on behind the scenes label Feb 8, 2024
michelengelen and others added 3 commits February 19, 2024 09:20
@michelengelen @oliviertassinari
Update .github/ISSUE_TEMPLATE/1.bug.yml

Verified

This commit was signed with the committer’s verified signature.
jksolbakken Jan-Kåre Solbakken
SSH Key Fingerprint: G6hWnLQvnFWO0td0XHBvn5XqXHtIdr8jDTgqdQ84rFM
Verified
Learn about vigilant mode
Loading
Loading status checks…
35995bc 
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
@michelengelen
replaced all occurences of the utf8 param in search links
a7f9a6e
@michelengelen
Merge remote-tracking branch 'origin/issues/adjust-link-to-search-pag…
Loading
Loading status checks…
a33fd78 
…e' into issues/adjust-link-to-search-page
@michelengelen michelengelen enabled auto-merge (squash) February 21, 2024 15:21
@oliviertassinari
Copy link
Member

It looks good to me 👍 (not approving to be become depended on)

mnajdova
mnajdova approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes makes sense 👍 Thanks!

@michelengelen michelengelen merged commit aa2415a into mui:master Mar 1, 2024
22 checks passed
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
@michelengelen @oliviertassinari @mnajdova
[infra] Adjust the links to search for issues (mui#41008)
efd889f 
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova

@oliviertassinari oliviertassinari

Assignees

@michelengelen michelengelen

Labels
core Infrastructure work going on behind the scenes scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michelengelen @mui-bot @oliviertassinari @mnajdova