Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix selected tab on codeblocks #41036

Merged
merged 4 commits into from Feb 12, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Feb 9, 2024

Potentially the smallest PR I've ever opened 😅 Just fixing the class name of the selected tab on code blocks.

A regression from #40205

@danilo-leal danilo-leal added bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product labels Feb 9, 2024
@danilo-leal danilo-leal self-assigned this Feb 9, 2024
@mui-bot
Copy link

mui-bot commented Feb 9, 2024

Netlify deploy preview

https://deploy-preview-41036--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1ca0a0a

@oliviertassinari oliviertassinari added the regression A bug, but worse label Feb 10, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 10, 2024

General note

If we could systematically reference regressions by adding the regression label on top of bug, referencing the PR who broke it, and asking for a review from the author of the regression PR, it would be great.

For instance, this is a great case to why we need https://www.notion.so/mui-org/code-infra-Website-docs-visual-regression-6fe97a982e0b4536a77292090c1c16be. This is also important for the person who did the work in the first place, gaining a stronger understanding on the true requirement to make the change happen.

Off-topic

In the file, const StyledTab = styled(Tab)< I hate this so much, but const Tab = styled(TabBase)< 😌

@danilo-leal
Copy link
Contributor Author

@oliviertassinari That makes sense! I've seen you doing this formatting and standardization a couple of times now, and I think that for it to be adopted, we need first to document this guideline somewhere that's easier to find — PR comments can be too ephemeral. I've started adding it to the "GitHub PRs" Notion page (we can think about better places for it if needed).

@danilo-leal danilo-leal merged commit b9a6d1e into mui:master Feb 12, 2024
18 checks passed
@danilo-leal danilo-leal deleted the fix-codeblock-selected-tab branch February 12, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work regression A bug, but worse scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants