[material-ui][Autocomplete] Caret transformation issue with font size change #41066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-41066--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
dpertsin
changed the title
|
So, I discovered that if we remove the 'right: 0;' style, the other Autocomplete components are changing, so I will add this back. |
zannager
added
the
component: autocomplete
So, I discovered that if we remove the 'right: 0;' style, the other Autocomplete components are changed and the caret icon goes to the left side, so I will add this back. Signed-off-by: Dimitris Pertsinidis <76684058+dpertsin@users.noreply.github.com>
Because the Argos tool detected some changes I had to change the style. Signed-off-by: Dimitris Pertsinidis <76684058+dpertsin@users.noreply.github.com>
Signed-off-by: Dimitris Pertsinidis <76684058+dpertsin@users.noreply.github.com>
oliviertassinari
changed the title
DiegoAndai
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Thanks @dpertsin! 🎉
The CI check failing is not for this PR in particular, but it's failing on multiple PRs; I will merge this as soon as we figure out why that check is failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caret icon within the Autocomplete component was incorrectly positioned due to the following styles applied to the .css-1q60rmi-MuiAutocomplete-endAdornment class:
This caused the caret icon to be misaligned when the font size was adjusted. Additionally, the 'right: 0;' style was redundant and was overridden by another class, so I removed it..
Bug Fix:
The caret icon's positioning is now consistent and follows the standard Material-UI styling.
Fix #40874